Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create action to automatically migrate web-features tags to BCD #2471

Closed
wants to merge 1 commit into from

Conversation

queengooborg
Copy link
Contributor

This PR adds a GitHub Actions workflow that will run the BCD tags migration script automatically and create a pull request in BCD.

Note: for this action to function, a token for a bot account that has access to BCD must be obtained and provided.

@github-actions github-actions bot added the tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings label Dec 18, 2024
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together, Vinyl. Here's what I've learned:

I'm fairly certain that this workflow should reside in the BCD repository. For one, I don't love the idea of having privileged access to BCD shared into web-features. And another is that the absolute timing and frequency of generated PRs seems like it should be under the control of BCD maintainers (e.g., to match reviewer availability), not web-features'.

It might be good to have another look at #1672 (comment) to see what I supposed the workflow for migrating tags into BCD would look like as a routine, ongoing matter.

All that said, I might've missed something here and would love to know if there are compelling reasons to run this workflow out of web-features, apart from the existence of the migrate script here.

@Elchi3
Copy link
Collaborator

Elchi3 commented Jan 9, 2025

Per #1672 this should live in BCD and I think it would be nice if it gets triggered whenever dependabot updates web-features for BCD.

@Elchi3 Elchi3 closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants