Skip to content

Commit

Permalink
Revert of Fix crash when accessing Event::path(). (patchset #4 id:600…
Browse files Browse the repository at this point in the history
…01 of https://codereview.chromium.org/516843004/)

Reason for revert:
The test crash-on-querying-event-path.html is unacceptably flaky.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT%20Blink&tests=http%2Ftests%2Fdom%2Fcrash-on-querying-event-path.html&testType=layout-tests


Original issue's description:
> Fix crash when accessing Event::path().
> 
> (A more elaborate account of the details is found in the bug report.)
> 
> BUG=400476
> [email protected]
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181200

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=400476

Review URL: https://codereview.chromium.org/532593002

git-svn-id: svn://svn.chromium.org/blink/trunk@181205 bbb929c8-8fbe-4397-9dbb-9b2b20218538
  • Loading branch information
tkent-google committed Sep 2, 2014
1 parent bf04efd commit cdb61b0
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 58 deletions.

This file was deleted.

45 changes: 0 additions & 45 deletions LayoutTests/http/tests/dom/crash-on-querying-event-path.html

This file was deleted.

2 changes: 1 addition & 1 deletion Source/core/events/Event.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ EventTarget* Event::currentTarget() const
if (SVGElement* svgElement = toSVGElement(node)->correspondingElement())
return svgElement;
}
return m_currentTarget.get();
return m_currentTarget;
}

void Event::trace(Visitor* visitor)
Expand Down
2 changes: 1 addition & 1 deletion Source/core/events/Event.h
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ class Event : public RefCountedWillBeGarbageCollectedFinalized<Event>, public S
bool m_cancelBubble;

unsigned short m_eventPhase;
RefPtrWillBeMember<EventTarget> m_currentTarget;
RawPtrWillBeMember<EventTarget> m_currentTarget;
RefPtrWillBeMember<EventTarget> m_target;
DOMTimeStamp m_createTime;
RefPtrWillBeMember<Event> m_underlyingEvent;
Expand Down

0 comments on commit cdb61b0

Please sign in to comment.