FetchEvent should not forcibly reject an unresolved Promise when dest…

…ructed

Currently an unresolved Promise on RespondWithObserver is forcibly rejected
when the RespondWithObserver is destructed. This means that an unresolved Promise
registered with fetchEvent.respondWith() is forcibly rejected when the fetchEvent
is destructed. This behavior is not good because it makes GC observable.
(For more details, see comment #2 and #4 in the CL discussion.)

Given the above, this CL stops rejecting an unresolved Promise in
RespondWithObserver's destructor. Also this CL removes a test that were
testing the behavior. The removed test should hang after this change
(because an unresolved Promise is never resolved nor rejected).

BUG=400645

Review URL: https://codereview.chromium.org/442183003

git-svn-id: svn://svn.chromium.org/blink/trunk@179695 bbb929c8-8fbe-4397-9dbb-9b2b20218538

LayoutTests/http/tests/serviceworker/fetch-event.html

@@ -120,24 +120,6 @@
       .catch(unreached_rejection(t));
 }());
 
-(function() {
-    var t = async_test(
-        'Service Worker responds to fetch event with unresolved promise');
-    var scope = 'resources/simple.html?unresolved';
-    service_worker_unregister_and_register(t, worker, scope)
-      .then(t.step_func(function(sw) {
-          return wait_for_state(t, sw, 'activated');
-        }))
-      .then(t.step_func(function() { return with_iframe(scope); }))
-      .then(t.step_func(function(frame) {
-          assert_equals(frame.contentDocument.body.textContent,
-                        'Here\'s a simple html file.\n',
-                        'Response should come from fallback to native fetch');
-          return service_worker_unregister_and_done(t, scope);
-        }))
-      .catch(unreached_rejection(t));
-}());
-
 (function() {
     var t = async_test('Service Worker fetches other file in fetch event');
     var scope = 'resources/simple.html?fetch';

LayoutTests/http/tests/serviceworker/resources/fetch-event-test-worker.js

@@ -20,10 +20,6 @@ function handleReject(event) {
     }));
 }
 
-function handleUnresolved(event) {
-    event.respondWith(new Promise(function(resolve, reject) { }));
-}
-
 function handleFetch(event) {
     event.respondWith(fetch('other.html'));
 }
@@ -37,7 +33,6 @@ self.addEventListener('fetch', function(event) {
         { pattern: '?ignore', fn: function() {} },
         { pattern: '?null', fn: handleNullBody },
         { pattern: '?reject', fn: handleReject },
-        { pattern: '?unresolved', fn: handleUnresolved },
         { pattern: '?fetch', fn: handleFetch }
     ];
 

Source/modules/serviceworkers/RespondWithObserver.cpp

@@ -62,8 +62,6 @@ PassRefPtr<RespondWithObserver> RespondWithObserver::create(ExecutionContext* co
 
 RespondWithObserver::~RespondWithObserver()
 {
-    if (m_state == Pending)
-        sendResponse(nullptr);
 }
 
 void RespondWithObserver::contextDestroyed()