chore(backward): move compat tests to avoid compiling them everytime #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
reviewed
Jan 9, 2025
Cargo.toml
Outdated
| @@ -11,10 +11,11 @@ members = [ | |||
| "backends/tfhe-cuda-backend", | |||
| "utils/tfhe-versionable", | |||
| "utils/tfhe-versionable-derive", | |||
| "tests" | |||
There was a problem hiding this comment.
this is a tab, please enable editor config
There was a problem hiding this comment.
I have it but .editorconfigonly sets space for .rs files
There was a problem hiding this comment.
then let's update it for .c .h and .toml files as well
nsarlin-zama
force-pushed
the
ns/chore/move_backward_compat_test
branch
from
fa63d77 to
14e1810
Compare
nsarlin-zama
force-pushed
the
ns/chore/move_backward_compat_test
branch
from
14e1810 to
18e6290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/867
PR content/description
Moved it to a workspace level "tests" folder, that way they are run with
cargo test -p testsor when doingcargo testin the workspace root, but I don't think that we are doing this