Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync soundfont_compiler.c with recent OoT change, give automatic names to sequence 0 channels that implement sfx #1784

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Sync soundfont_compiler.c with recent OoT change, give automatic names to sequence 0 channels that implement sfx #1784

wants to merge 2 commits into from
+3,998 −4,001

Conversation

Thar0
Copy link
Contributor

@Thar0 Thar0 commented Jan 7, 2025

sfc source was change in oot as part of zeldaret/oot#2396

hensldm
hensldm approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@hensldm hensldm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes look good, though looks like we are getting an incorrect checksum on Jenkins.

include/audio/soundfont.h Show resolved Hide resolved
@hensldm hensldm added Audio Waiting-for-author Author needs fix to conflicts or address reviews Needs-second-approval Second approval labels Jan 7, 2025
@hensldm hensldm removed the Waiting-for-author Author needs fix to conflicts or address reviews label Jan 7, 2025
@AngheloAlf AngheloAlf added Merge-ready All reviewers satisfied, just waiting for CI and removed Needs-second-approval Second approval labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hensldm hensldm hensldm approved these changes

@AngheloAlf AngheloAlf AngheloAlf approved these changes

Assignees
No one assigned
Labels
Audio Merge-ready All reviewers satisfied, just waiting for CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thar0 @AngheloAlf @hensldm