Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke test with non-legacy yarn version #696

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
+124 −54
Draft

Smoke test with non-legacy yarn version #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea05c35
Smoke test with non-legacy yarn version
rotu Jan 6, 2025
4e7b1a9
Move cmake-ts to optionalDependencies
rotu Jan 6, 2025
e5a37be
Move `node-addon-api` to optionalDependencies
rotu Jan 6, 2025
5bb176c
Merge branch 'master' into blonde-damselfly
rotu Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ jobs:
- name: Install Yarn Latest
if: matrix.node-version == 22
run: |
npm i -g yarn@latest
npm i -g @yarnpkg/cli-dist@latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you separate any change other than the version bump?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Moving this back to draft while I figure out what all is needed to make the smoke tests pass then I'll split it up as needed.


- name: Install Pnpm 5
if: matrix.node-version == 10
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@
"url": "https://github.com/zeromq/zeromq.js.git"
},
"homepage": "http://zeromq.github.io/zeromq.js/",
"dependencies": {
"@aminya/cmake-ts": "^0.3.0-aminya.7",
"node-addon-api": "^8.3.0"
},
"devDependencies": {
"@types/benchmark": "~2.1.5",
"@types/chai": "^4",
Expand Down Expand Up @@ -66,6 +62,10 @@
"typescript": "~4.9.5",
"which": "^5.0.0"
},
"optionalDependencies": {
"@aminya/cmake-ts": "0.3.0-aminya.7",
"node-addon-api": "^8.3.0"
},
"pnpm": {
"overrides": {
"typescript": "~4.9.5",
Expand Down
Loading
Loading