Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helped me solving the problem we face with smokescreen when some of your services are on a private network. Entirely disabling it does not looks like a good idea, plus I did not manage to do that because everything broke when I added the usual:
thing. So! This uses dockerfile's entrypoint
runPostSetupScripts
and allows me to list my whitelisted addressed so everything works well!How did you test this PR?
Hope this helps, ciao!