Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified code for google calendar integration #848

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

modified code for google calendar integration #848

wants to merge 2 commits into from

Conversation

octocamocoder47
Copy link

@octocamocoder47 octocamocoder47 commented Jan 4, 2025 •
edited
Loading

modified code for google calendar integration according to google calendar new API manual

Fixes: #847 (#847 )

How did you test this PR?

I couldn't test PR because I don't have api keys and proper env setup to test it.

  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the Google Calendar integration
3 participants
@octocamocoder47 @zulipbot @pransh62390