-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved reconnect error page #872
Conversation
@meyash hey, thanks for the contributing to the project. This looks nice. I think there is still a room for improvements for the content (list items, button alignment). Also, I would suggest please discuss the changes, ask for feedback etc in #desktop stream on https://chat.zulip.org/ and then open a PR. This will save a lot of your time :) |
@timabbott @vsvipul |
@meyash can you try out some UI for this? Once done, we can merge this. |
@akashnimare |
@meyash Doesn't look good enough. We need to keep it clean and make it look good simultaneously. |
Can you suggest some changes i can make? |
Heads up @meyash, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
How can i fix the conflicts? |
@meyash Read a tutorial online on how to do so. Just google the words on how to do so. |
What's this PR do?
Improved reconnect error page fixes #862
Any background context you want to provide?
Improved network.html and network.css
Screenshots?
You have tested this PR on: