Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Zulip feature level on ApiConnection; use it #146

Closed
gnprice opened this issue Jun 1, 2023 · 2 comments · Fixed by #159
Closed

Track Zulip feature level on ApiConnection; use it #146

gnprice opened this issue Jun 1, 2023 · 2 comments · Fixed by #159
Assignees
Labels
a-api Implementing specific parts of the Zulip server API
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Jun 1, 2023

This will let us do our part for server API migrations, by using the new API where available so that this client isn't a compatibility obstacle for future server versions to drop the old API.

In particular, this means:

@gnprice gnprice added the a-api Implementing specific parts of the Zulip server API label Jun 1, 2023
@gnprice gnprice added this to the Alpha milestone Jun 1, 2023
@gnprice
Copy link
Member Author

gnprice commented Jun 1, 2023

(Once we've set this up once, it'll be easy to do the same thing along the way as we add more to the API bindings. So it's easiest if we do this early.)

@chrisbobbe
Copy link
Collaborator

This seems quite helpful for #140 (see discussion of FL 120+ condition there), which in turn will be useful for quote-and-reply #116. So the "Alpha" milestone seems appropriate. 🙂

@gnprice gnprice self-assigned this Jun 5, 2023
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jun 5, 2023
…d code

There was only one occurrence in the UI, in [DmRecipientHeader].

The remaining few places we refer to the old names are in the
context of the server API.  We have issue zulip#146 open to start using
the new names there where possible.

Fixes: zulip#145
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jun 5, 2023
…d code

There was only one occurrence in the UI, in [DmRecipientHeader].

The remaining few places we refer to the old names are in the
context of the server API.  We have issue zulip#146 open to start using
the new names there where possible.

Fixes: zulip#145
chrisbobbe pushed a commit that referenced this issue Jun 6, 2023
…d code

There was only one occurrence in the UI, in [DmRecipientHeader].

The remaining few places we refer to the old names are in the
context of the server API.  We have issue #146 open to start using
the new names there where possible.

Fixes: #145
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jun 8, 2023
This doesn't yet do anything, but it provides the infrastructure for
taking care of zulip#146: it sets us up to have individual route bindings
condition their behavior on the Zulip feature level as appropriate.
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jun 8, 2023
@gnprice gnprice closed this as completed in 3e797d4 Jun 8, 2023
@gnprice gnprice added a-sync Event queue; retry; local echo; races and removed a-sync Event queue; retry; local echo; races labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API
Projects
Status: Done
2 participants