-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sweep through UI strings to internationalize #1148
base: main
Are you sure you want to change the base?
Conversation
Thanks! This is a lot fewer new strings than I'd expected it to be. I guess we've been pretty good about i18n in new code for the past year or so. I did part of a sweep through
(Stopping there to switch to another task — the remaining code for that sweep is in the |
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Renamed the "composeBoxUnknownChannelName" string to generalize it. This also added a string for notification message that may contain '(unknown channel)'. Signed-off-by: Zixuan James Li <[email protected]>
This descriptions were taken from [VideoPlayerValue]. Signed-off-by: Zixuan James Li <[email protected]>
Ideally we should implement zulip#1080 for DMs title, but we might switch to showing avatars as the TODO indicated before we work on lists' proper translation. Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
This renames notifSelfUser to make it more general. Signed-off-by: Zixuan James Li <[email protected]>
Marking this for review as I think it would be a good checkpoint. I did a sweep with
As well as the The licenses one can probably be translated with For commits that are local to a file or a class, I use the more specific tag, otherwise |
Partial work for: