Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Fix weblate action's rights, and update generated code. #1192

Closed
wants to merge 2 commits into from

Conversation

alexmv
Copy link
Contributor

@alexmv alexmv commented Dec 20, 2024

No description provided.

@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Dec 20, 2024
@chrisbobbe chrisbobbe requested a review from gnprice December 20, 2024 16:25
Copy link
Member

@gnprice gnprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One substantive comment, one interesting nit, and one boring one.

.github/workflows/update-translations.yml Show resolved Hide resolved
.github/workflows/update-translations.yml Show resolved Hide resolved
.github/workflows/update-translations.yml Show resolved Hide resolved
@gnprice
Copy link
Member

gnprice commented Dec 20, 2024

Also it'd be great to get to test this (and similar PRs) before merging it to main.

I floated a possible solution for that just now in the chat thread:
https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/weblate.20translations.20.28.23F276.29/near/2011576

@alexmv
Copy link
Contributor Author

alexmv commented Jan 8, 2025

Closing in preference to #1262.

@alexmv alexmv closed this Jan 8, 2025
@alexmv alexmv deleted the action-rights-generated branch January 8, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants