msglist: In single-conversation view, make recipient headers not tappable.

[lakshya1goel]

Pull Request Description

Summary
This PR updates the behavior of recipient headers in the single-conversation view to make them non-tappable.

Related Issue: #1171

Changes:

Adjusted GestureDetector logic:
Updated the logic to conditionally enable navigation only when relevant.

Simplified ColoredBox structure:
Streamlined the layout for non-tappable headers to ensure consistent behavior and appearance.

Video Demonstration:

WhatsApp.Video.2024-12-20.at.10.39.41.PM.mp4

[chrisbobbe]

Thanks for the PR! It needs tests, and the commit message should say "Fixes" with the issue number. Also see two substantive comments below.

[lakshya1goel]

@chrisbobbe Please have a look on the changes now. Added tests as well. But getting the CI/check fails, showing

Failed to download https://storage.googleapis.com/flutter_infra_release/flutter/7df127b1ee7d52c4cb0d42eedd00190e2c4ade3d/flutter_patched_sdk_product.zip. Ensure you have network connectivity and then try again.
Exception: 404
Error: Process completed with exit code 1.

Please let me know how can I fix them, as I have the good internet connectivity still getting this.

[lakshya1goel]

@chrisbobbe , the checks have also been fixed now. Please review it once.
Thanks!

[chrisbobbe]

Thanks! Small comments below.

Also a commit-message nit:

msglist: In single-conversation view, make recipient headers not tappable.

Updated onTap for recipient headers in single-conversation view.
Adjusted GestureDetector logic to conditionally enable navigation.
Simplified ColoredBox structure for non-tappable recipient headers.
Improves user experience by removing unnecessary tap interactions.

Fixes: #1171

The paragraph isn't needed; it doesn't add anything that isn't already easy to see from the code change, or implied by the Fixes: #1171 line.

[lakshya1goel]

Hello, @chrisbobbe I have done the requested changes. Please have a look on them.
Thanks!

[chrisbobbe]

Thanks! Small comments below.

[lakshya1goel]

Hello @chrisbobbe, done with the changes mentioned in above comments.
Please take a moment to review them.
Thanks!

[chrisbobbe]

Thanks! Small comments below.

[lakshya1goel]

Hi, I have made the required changes. Please have a look on them.
Thanks!

[chrisbobbe]

Thanks! Comments below from a closer review, all small.

[lakshya1goel]

Thanks for the detailed review. Done with all the changes please have a look on it.
Thanks!

[chrisbobbe]

Thanks! Small nits below, otherwise LGTM.

[lakshya1goel]

Thanks for the review. I have made the changes. Please have a look.
Thanks!