Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder account list as desired #1253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rishichirchi
Copy link

Purpose: This pull request modifies the order of the accounts list in the account switcher page.

Changes:

  • Implemented a reorderable list for the accounts, allowing users to reorder accounts as needed.
  • The list supports drag-and-drop functionality to change the order of accounts.
  • Used ReorderableListView for smooth reordering and updated the UI to reflect changes immediately.

Impact:

  • The account list is now more user-friendly, as users can easily reorder their accounts.
  • This change enhances the user experience by providing flexibility in account management.

Fixes: #1161

screen-20250104-020457.mp4

@gnprice
Copy link
Member

gnprice commented Jan 3, 2025

Thanks for the contribution. Before we can review this, it will need tests, and it will need to have a clean diff without making lots of extraneous changes. See our README and the resources linked from there:
https://github.com/zulip/zulip-flutter?tab=readme-ov-file#submitting-a-pull-request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder account list when desired
2 participants