Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace announceForAccessibility() with announceForAccessibilityWithOptions() #5643

Conversation

1010nishant
Copy link

@1010nishant 1010nishant commented Jan 20, 2023

announceForAccessibility() replaced with announceForAccessibilityWithOptions().
By default, announcements will interrupt any existing speech. they can be queued behind existing speech by setting queue to true.
fixed: #5611

@chrisbobbe
Copy link
Contributor

Thanks! I see you created a different PR, #5642, for the same issue. In future please force-push to the same PR instead of making a new one.

@chrisbobbe
Copy link
Contributor

chrisbobbe commented Jan 20, 2023

I see CI is failing with a complaint from Prettier; please run tools/test prettier --fix and squash the fix into your commit. Then please amend your commit so that its commit message follows our style, and force-push to the same branch.

@1010nishant 1010nishant force-pushed the set-queue-on-accessibility-announcement branch from c0f31ea to 7efaba6 Compare January 21, 2023 14:25
@1010nishant 1010nishant force-pushed the set-queue-on-accessibility-announcement branch from 5b1092c to 966c36a Compare January 21, 2023 15:42
@1010nishant
Copy link
Author

I got stuck there. the command that you mentioned before is not working. I need your attention to it.
Screenshot 2023-01-22 at 7 11 07 PM
As a beginner, I am feeling very exhausted. Despite feeling exhausted, I am pushing my boundaries and pushing myself to achieve my goals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set queue on accessibility announcements in OfflineNoticeProvider
2 participants