Skip to content

Commit

Permalink
refactor: lint-hotkeys: Make the integer error flag boolean.
Browse files Browse the repository at this point in the history
  • Loading branch information
Niloth-p committed Jun 27, 2024
1 parent 4afff89 commit b02cbe6
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions tools/lint-hotkeys
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def lint_hotkeys_file() -> None:
existing OUTPUT_FILE
"""
hotkeys_file_string = get_hotkeys_file_string()
error_flag = 0 if is_every_key_category_valid() else 1
error_flag = not is_every_key_category_valid()
# To lint keys description
categories = read_help_categories()
for action in HELP_CATEGORIES:
Expand All @@ -53,7 +53,7 @@ def lint_hotkeys_file() -> None:
f"Description - ({help_text}) for key combination - [{various_key_combinations}]\n"
"It should contain only alphabets, spaces and special characters except ."
)
error_flag = 1
error_flag = True
# Check key combination duplication
check_duplicate_keys_list = [
key for key in check_duplicate_keys_list if key not in KEYS_TO_EXCLUDE
Expand All @@ -67,16 +67,16 @@ def lint_hotkeys_file() -> None:
print(
f"Duplicate key combination for keys {duplicate_keys} for category ({HELP_CATEGORIES[action]}) detected"
)
error_flag = 1
if error_flag == 1:
error_flag = True
if error_flag is True:
print(f"Rerun this command after resolving errors in config/{KEYS_FILE_NAME}")
else:
print("No hotkeys linting errors")
if not output_file_matches_string(hotkeys_file_string):
print(
f"Run './tools/{SCRIPT_NAME} --fix' to update {OUTPUT_FILE_NAME} file"
)
error_flag = 1
error_flag = True
sys.exit(error_flag)


Expand Down

0 comments on commit b02cbe6

Please sign in to comment.