Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for spoilers #688

Open
timabbott opened this issue Jun 14, 2020 · 2 comments · May be fixed by #1061 or #1529
Open

Add support for spoilers #688

timabbott opened this issue Jun 14, 2020 · 2 comments · May be fixed by #1061 or #1529
Labels
area: message rendering GSoC Possible GSoC project component high priority should be done as soon as possible missing feature: user A missing feature for all users, present in another Zulip client version parity: 3
Milestone
Next Release

Comments

@timabbott
Copy link
Member

See zulip/zulip#15281; we recently added markdown support for the spoilers feature, and it'd be valuable for zulip-terminal to at least not display the hidden text by default.
@timabbott timabbott mentioned this issue Jun 14, 2020
Closed
@neiljp
Copy link
Collaborator

neiljp commented Jun 15, 2020

@timabbott Thanks for filing this, I appreciate the heads-up.

At absolute minimum for v0 I'd expect us to hide the spoiler content, perhaps providing a link to the message on the server, though that's not necessary?

I'd suggest one v1 approach might be to integrate this with implementing a fix for #543 (for 'large' messages), showing the 'full' text in that view. That does combine two use-cases (see all of a message & see spoilers), which we could avoid by having a 'cycle' interface (not just toggle, but one key cycles, or exit with esc; or the new idea I raised for help/about of left/right panes/tabs/popups)

Another v1 approach may be to put this in the scope of viewing 'extended content', ie. listing images, links, etc. However, that loses the context in the message.

@neiljp neiljp mentioned this issue Jun 15, 2020
Open
12 tasks
@neiljp neiljp added the high priority should be done as soon as possible label Jul 30, 2020
@neiljp neiljp added this to the Release after upcoming milestone Jul 30, 2020
@neiljp
Copy link
Collaborator

neiljp commented Oct 20, 2020 •
edited
Loading

This was discussed in #zulip-terminal>Spoilers! #T688 #T1061 #T1173 on chat.zulip.org.

@neiljp neiljp added the missing feature: user A missing feature for all users, present in another Zulip client label Apr 5, 2021
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jul 2, 2021
@Ezio-Sarthak
views: Show SpoilerButton in message info view if present.
3c2836b 
This commit wraps-up the PR by appending the SpoilerButton to message
info view if present.

Co-authored by: Preet Mishra (<[email protected]>).
Fixes zulip#688.
@Ezio-Sarthak Ezio-Sarthak linked a pull request Jul 2, 2021 that will close this issue
Open
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jul 3, 2021
@Ezio-Sarthak
views: Show SpoilerButton in message info view if present.
bd66682 
This commit wraps-up the PR by appending the SpoilerButton to message
info view if present.

Co-authored-by: Preet Mishra <[email protected]>

Fixes zulip#688.
Ezio-Sarthak added a commit to Ezio-Sarthak/zulip-terminal that referenced this issue Jul 3, 2021
@Ezio-Sarthak @preetmishra
views: Show SpoilerButton in message info view if present.
8c5e15a 
This commit wraps-up the PR by appending the SpoilerButton to message
info view if present.

Fixes zulip#688.

Co-authored-by: Preet Mishra <[email protected]>
@neiljp neiljp added the GSoC Possible GSoC project component label Mar 5, 2022
@neiljp neiljp mentioned this issue Mar 20, 2022
Merged
4 tasks
@rsashank rsashank linked a pull request Jul 3, 2024 that will close this issue
Open
18 tasks
rsashank added a commit to rsashank/zulip-terminal that referenced this issue Jul 12, 2024
@rsashank
buttons/core/messages/view: Add spoiler_link to metadata.
79f395b 
This commit:
 * Adds a boolean value spoiler_link to metadata, indicating
   whether a link is part of spoiler content.
 * Adds [spoiler] to link caption if spoiler_link is True.

Fixes zulip#688.
rsashank added a commit to rsashank/zulip-terminal that referenced this issue Jul 12, 2024
@rsashank
buttons/core/messages/view: Add spoiler_link to metadata.
c38bb42 
This commit:
 * Adds a boolean value spoiler_link to metadata, indicating
   whether a link is part of spoiler content.
 * Adds [spoiler] to link caption if spoiler_link is True.

Fixes zulip#688.
rsashank added a commit to rsashank/zulip-terminal that referenced this issue Jul 12, 2024
@rsashank
buttons/core/messages/view: Add spoiler_link to metadata.
6f7fbdf 
This commit:
 * Adds a boolean value spoiler_link to metadata, indicating
   whether a link is part of spoiler content.
 * Adds [spoiler] to link caption if spoiler_link is True.

Fixes zulip#688.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: message rendering GSoC Possible GSoC project component high priority should be done as soon as possible missing feature: user A missing feature for all users, present in another Zulip client version parity: 3
Projects
None yet
Milestone
Next Release
2 participants
@timabbott @neiljp