Hide spoiler content in notifications #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neiljp
force-pushed
the
2022-03-18-hide-spoilers-in-notifications
branch
from
c48b596 to
b2f7d74
Compare
This was added to the web app in zulip/zulip@ea1c1783057a609972040d34ab2a. Tests extended.
neiljp
force-pushed
the
2022-03-18-hide-spoilers-in-notifications
branch
from
b2f7d74 to
244ca3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is complementary to #1061, which is aimed at the message content and accessing the hidden content. #688 doesn't discuss the specifics, but hiding in notifications is one part of this.
This PR migrates the html processing from the platform code into the model, where beautiful soup is used to translate and extract content accordingly.
Prior to this PR, spoiler text in a message gives rise to extra lines of text and doesn't hide the spoiler content. The updated output is intended to match the style from the web app, which translates a spoiler with a
titleandcontentintotitle (...)in a notification.Tested?
Notes & Questions
This provides good infrastructure for a follow-up set of work to explore how different markdown is rendered in notifications and improve it if necessary.