Rebase and simplification of #870 #1161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the need to understand all details of the stream compose in order to follow the stream message edit setup, and should help with further refactoring. Co-authored-by: Abhirup-99 <[email protected]>
Fixes zulip#774. Co-authored-by: Abhirup-99 <[email protected]>
zulipbot
added
size: L
neiljp
added
the
PR ready to be merged
|
This is now merged as 80bb9c0 and the two prior commits, so I'm going to manually close this. |
This was referenced Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a rebase and simplification of #870, which is a partial fix for #774.
I'd appreciate feedback from anyone who contributed to that issue.
Tested?
Commit flow
After rebasing and fixing formatting, this splits the original PR into a refactor and feature commit. Around these there are various simplifying commits, most of which I expect to squash with those two before merging - though I may leave them in this PR for future reference by others in terms of tidying a previous PR.
Notes & Questions
This doesn't fully fix the issue, since it doesn't handle private messages, so anyone is welcome to take that up separately.
This also exposes how we could further simplify and refactor the compose code, though considering older PRs may be good to do to avoid them bit-rotting further too :)