-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split test_ui_tools to multiple smaller test files. #422
Conversation
__init__.py created to convert it to be used as a package.
@sumanthvrao Zulip server has used a tool to work with that issue, which I think is |
Great! I'm looking into it. |
Here's an output of running the tool for
Around 10 open PRs have changes involving some parts of |
@sumanthvrao How are the conflicts looking like now? |
@neiljp I believe they are still the same amount of conflicts which would probably appear if we got merged. |
* This commit introduces the change, while the actual linking has been done in a follow up commit. * Tests for views have been moved to a separate folder, along the lines of zulip#422. * The update_user_list function has been marked x-fail for now.
Heads up @sumanthvrao, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
This was a useful investigation 👍 However, this has been open a long time, and we made this transition initially starting some tests in separate files, and moving them across in fa2fbed for buttons, and d5a22ba for messages (into a distinct test_messages.py). It would likely still be useful to make changes such as:
I've filed the latter suggestions as #1508 so this isn't lost. |
The reason for this change is to