[wip] wl: Add CogWlPlatform fullscreen-enter and fullscreen-exit signals #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psaavedra
force-pushed
the
psaavedra/main-refactorings-resized-window-and-fullscreen-signals
branch
2 times, most recently
from
0f63328 to
17c2699
Compare
psaavedra
changed the title
psaavedra
force-pushed
the
psaavedra/main-refactorings-resized-window-and-fullscreen-signals
branch
2 times, most recently
from
4ec4284 to
df36993
Compare
psaavedra
force-pushed
the
psaavedra/main-refactorings-resized-window-and-fullscreen-signals
branch
3 times, most recently
from
3a952e9 to
1b96d92
Compare
psaavedra
changed the title
psaavedra
force-pushed
the
psaavedra/main-refactorings-resized-window-and-fullscreen-signals
branch
from
1b96d92 to
3c027d4
Compare
psaavedra
changed the title
In the Platform side the fullscreen enter/exit logic was cleaned up, simplified and encapsulated in the cog_wl_platform_[enter|exit]_fullscreen functions. The CogWlPlatform is not responsible of having in consideration the state of the view. It is limited to do store the previous geometry, to set the new window geometry and to make the adjustments in the corresponding shell. Finally, the View associated to the Platform is notified using the new cog_wl_view_[enter|exit]_fullscreen functions and relies on the View to do the rest. The CogWlView reacts those notifications by sending the wpe_view_backend_dispatch_did_enter_fullscreen and wpe_view_backend_dispatch_did_exit_fullscreen according with the notification.
Simply the code in CogWlPlatform by adding the "fullscreen-enter" and "fullscreen-exit" signals to notify to the view that the window is being entering or exiting from the fullscreen. This change is motivated towards the progress of being able to have more than one view.
psaavedra
force-pushed
the
psaavedra/main-refactorings-resized-window-and-fullscreen-signals
branch
from
3c027d4 to
2e961f6
Compare
psaavedra
changed the title
|
Discarded for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply the code in CogWlPlatform by adding the "fullscreen-enter" and "fullscreen-exit" signals to notify to the view that the window is being entering or exiting from the fullscreen.
This change is motivated towards the progress of being able to have more than one view.
DEPENDS ON: #629