Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add python 3.12 and django 5.0 #2059

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

marksweb
Copy link
Contributor

This adds python 3.12 and django 5.0 while dropping python 3.7.

Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks.

@smithdc1 smithdc1 merged commit 33db839 into django:main Nov 23, 2023
6 checks passed
@marksweb marksweb deleted the test/py312 branch November 23, 2023 23:26
@palfrey
Copy link

palfrey commented Feb 8, 2024

Any thoughts about a release with this in?

@marksweb
Copy link
Contributor Author

marksweb commented Feb 8, 2024

@palfrey There's no actual code changes to the app here, just testing against django 5 and python 3.12. So you should be able to use these versions with the current releaase.

@palfrey
Copy link

palfrey commented Feb 8, 2024

Huh, you're right! I'd had to upgrade various things when I did a Django 3.2 -> 5.0 upgrade and I must have thought this was one of the ones with problems, but nope. All good, thanks.

@carltongibson
Copy link
Member

Thanks @marksweb, exactly.

But for information, I'm pottering towards an update for Daphne at the moment, and then will swing round to Channels again. (Channels-Redis had one just recently.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants