Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add python 3.12 and django 5.0 #2059

Merged
merged 2 commits into from
Nov 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ jobs:
fail-fast: false
matrix:
python-version:
- "3.7"
- "3.8"
- "3.9"
- "3.10"
- "3.11"
- "3.12"

steps:
- uses: actions/checkout@v4
Expand Down
11 changes: 9 additions & 2 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,20 @@ Make sure the tests pass:
.. code-block:: sh

python -m pip install -e .[tests]
pytest
tox

.. note::
If you're using ``zsh`` for your shell, the above command will fail with a
``zsh: no matches found: .[tests]`` error.
To fix this use ``noglob``::

noglob python -m pip install -e .[tests]

Make your change. Add tests for your change. Make the tests pass:

.. code-block:: sh

pytest
tox

Make sure your code conforms to the coding style:

Expand Down
4 changes: 2 additions & 2 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ and `tutorial <https://channels.readthedocs.io/en/latest/tutorial/index.html>`_
Dependencies
------------

All Channels projects currently support Python 3.7 and up. ``channels`` is
compatible with Django 3.2, 4.0, 4.1, and 4.2.
All Channels projects currently support Python 3.8 and up. ``channels`` is
compatible with Django 3.2, 4.0, 4.1, 4.2 and 5.0.


Contributing
Expand Down
5 changes: 3 additions & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,19 @@ classifiers =
Operating System :: OS Independent
Programming Language :: Python
Programming Language :: Python :: 3
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Programming Language :: Python :: 3.12
Framework :: Django
Framework :: Django :: 3
Framework :: Django :: 3.2
Framework :: Django :: 4
Framework :: Django :: 4.0
Framework :: Django :: 4.1
Framework :: Django :: 4.2
Framework :: Django :: 5.0
Topic :: Internet :: WWW/HTTP

[options]
Expand All @@ -36,7 +37,7 @@ include_package_data = True
install_requires =
Django>=3.2
asgiref>=3.5.0,<4
python_requires = >=3.7
python_requires = >=3.8

[options.extras_require]
tests =
Expand Down
6 changes: 4 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
[tox]
envlist =
py{37,38,39,310}-dj32
py{38,39,310}-dj32
py{38,39,310}-dj40
py{38,39,310,311}-dj41
py{38,39,310,311}-dj42
py{310,311}-djmain
py{310,311,312}-dj50
py{310,311,312}-djmain
qa

[testenv]
Expand All @@ -16,6 +17,7 @@ deps =
dj40: Django>=4.0,<4.1
dj41: Django>=4.1.2,<4.2
dj42: Django>=4.2,<5.0
dj50: Django>=5.0rc1,<5.1
djmain: https://github.com/django/django/archive/main.tar.gz

[testenv:qa]
Expand Down