Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire exercise .gitignore #254

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

keiravillekode
Copy link
Contributor

No description provided.

Copy link

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I wonder, in terms of Chesterton's Fence...

@@ -32,6 +32,5 @@ read -p "What's the difficulty for ${slug}? " difficulty
bin/fetch-configlet
bin/configlet create --practice-exercise "${slug}" --author "${author}" --difficulty "${difficulty}"

cp exercises/practice/hello-world/.gitignore exercises/practice/${slug}/.gitignore
Copy link
Member

@kotp kotp Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a reason why this was here in the first place and so removing this is likely to impact something.

Is there documentation to update that addresses what this change is going to make happen, either in the view of the student, or the view of the maintainers?

How does this change impact what happens in this project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put that there, to automate making new exercises like the existing exercises.

Bur we don't have any reason why the existing exercises had .gitignore

@kotp
Copy link
Member

kotp commented Dec 31, 2024

I do not have cross-track-maintainers access any more, if I had it before, so my approval is not effective here.

@keiravillekode keiravillekode merged commit 2a55913 into exercism:main Dec 31, 2024
7 checks passed
@keiravillekode keiravillekode deleted the retire-gitignore branch December 31, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants