-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retire exercise .gitignore #254
Conversation
Hello 👋 Thanks for your PR. This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed. If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track. Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum. (cc @exercism/cross-track-maintainers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I wonder, in terms of Chesterton's Fence...
@@ -32,6 +32,5 @@ read -p "What's the difficulty for ${slug}? " difficulty | |||
bin/fetch-configlet | |||
bin/configlet create --practice-exercise "${slug}" --author "${author}" --difficulty "${difficulty}" | |||
|
|||
cp exercises/practice/hello-world/.gitignore exercises/practice/${slug}/.gitignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a reason why this was here in the first place and so removing this is likely to impact something.
Is there documentation to update that addresses what this change is going to make happen, either in the view of the student, or the view of the maintainers?
How does this change impact what happens in this project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put that there, to automate making new exercises like the existing exercises.
Bur we don't have any reason why the existing exercises had .gitignore
I do not have cross-track-maintainers access any more, if I had it before, so my approval is not effective here. |
No description provided.