Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire exercise .gitignore #254

Merged
merged 1 commit into from
Dec 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bin/create-exercise
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,5 @@ read -p "What's the difficulty for ${slug}? " difficulty
bin/fetch-configlet
bin/configlet create --practice-exercise "${slug}" --author "${author}" --difficulty "${difficulty}"

cp exercises/practice/hello-world/.gitignore exercises/practice/${slug}/.gitignore
Copy link
Member

@kotp kotp Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a reason why this was here in the first place and so removing this is likely to impact something.

Is there documentation to update that addresses what this change is going to make happen, either in the view of the student, or the view of the maintainers?

How does this change impact what happens in this project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put that there, to automate making new exercises like the existing exercises.

Bur we don't have any reason why the existing exercises had .gitignore

cp exercises/practice/hello-world/Makefile exercises/practice/${slug}/Makefile
cp -r exercises/practice/hello-world/vendor exercises/practice/${slug}/vendor
2 changes: 0 additions & 2 deletions exercises/practice/acronym/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/affine-cipher/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/allergies/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/armstrong-numbers/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/atbash-cipher/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/binary-search/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/bob/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/book-store/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/difference-of-squares/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/eliuds-eggs/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/grains/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/hamming/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/hello-world/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/isbn-verifier/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/isogram/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/leap/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/list-ops/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/luhn/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/matching-brackets/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/nucleotide-count/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/pangram/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/pascals-triangle/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/phone-number/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/prime-factors/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/protein-translation/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/queen-attack/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/raindrops/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/resistor-color-duo/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/resistor-color/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/reverse-string/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/rna-transcription/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/roman-numerals/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/rotational-cipher/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/run-length-encoding/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/scrabble-score/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/space-age/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/square-root/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions exercises/practice/two-fer/.gitignore

This file was deleted.