Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Changed encodedTx #1444

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

StarGachinum
Copy link

Resolved issue #1442 .
Changed const encodedTx = transaction.encode();
to const encodedTx = new Uint8Array(sha256.sha256.array(transaction.encode()));

Copy link

changeset-bot bot commented Dec 28, 2024

⚠️ No Changeset found

Latest commit: 5afd9db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@StarGachinum StarGachinum changed the base branch from minor-fix to master December 28, 2024 12:34
@StarGachinum StarGachinum marked this pull request as draft December 30, 2024 13:04
@gagdiez
Copy link
Contributor

gagdiez commented Jan 5, 2025

I see that actually signMessage already applies the sha256, so maybe instead of changing the payload being signed, we just need to clarify what signMessage does on its String, and add a test

simply changing this code without a proper test would lead to more errors down the line

Copy link
Contributor

@gagdiez gagdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that actually signMessage already applies the sha256, so maybe instead of changing the payload being signed, we just need to clarify what signMessage does on its String, and add a test

simply changing this code without a proper test would lead to more errors down the line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants