Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Changed encodedTx #1444

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fix: Changed encodedTx #1444

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c802776
Fixed signing issue
StarGachinum Dec 28, 2024
bea74bd
Fixed return
StarGachinum Dec 28, 2024
5afd9db
fix: passed correct ts hash func
Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/client/src/transactions/sign_and_send.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const DEFAULT_FINALITY: BlockReference = { finality: 'final' };
* @param signer MessageSigner
*/
export async function signTransaction({ transaction, deps: { signer } }: SignTransactionParams) {
const encodedTx = transaction.encode();
const encodedTx = new Uint8Array(sha256(transaction.encode()));
const signedTransaction = new SignedTransaction({
transaction,
signature: new Signature({
Expand All @@ -25,7 +25,7 @@ export async function signTransaction({ transaction, deps: { signer } }: SignTra
});

return {
encodedTransactionHash: new Uint8Array(sha256(encodedTx)),
encodedTransactionHash: encodedTx,
signedTransaction,
};
}
Expand Down