Migrate all Java/Hamcrest tests to Kotlin/AssertK #13884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234
syntaxDescription
I'm working towards removing Hamcrest from the project, and replacing it with AssertK. Likewise, I've been working on migrating all of the Java tests to Kotlin.
The goal of this current PR is to:
hamcrest
To find them, I did:
rg -i hamcrest $(git ls-files "*.java")
These were the tests that met those conditions:
app/src/test/java/org/thoughtcrime/securesms/contacts/SelectedContactSetTest.kt
app/src/test/java/org/thoughtcrime/securesms/groups/v2/ProfileKeySetTest.kt
app/src/test/java/org/thoughtcrime/securesms/groups/v2/processing/GroupStatePatcherTest.kt
app/src/test/java/org/thoughtcrime/securesms/groups/v2/processing/StateChainTest.kt
app/src/test/java/org/thoughtcrime/securesms/l10n/SupportArticleTest.kt
app/src/test/java/org/thoughtcrime/securesms/recipients/RecipientIdSerializationTest.kt
app/src/test/java/org/thoughtcrime/securesms/service/webrtc/collections/ParticipantCollectionTest.kt
libsignal-service/src/test/java/org/whispersystems/signalservice/api/groupsv2/DecryptedGroupUtilTest.kt
libsignal-service/src/test/java/org/whispersystems/signalservice/api/groupsv2/GroupsV2Operations_ban_Test.kt
After the changes, I validated that
./gradlew qa
is still passing:And that there are no longer any files that match the search: