Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable cycling to stream and recipients while editing #774

Open
kaustubh-nair opened this issue Aug 15, 2020 · 11 comments · May be fixed by #1504
Open

Disable cycling to stream and recipients while editing #774

kaustubh-nair opened this issue Aug 15, 2020 · 11 comments · May be fixed by #1504
Assignees
@zormit
Labels
area: message editing enhancement New feature or request good first issue Good for newcomers help wanted This issue should be clear enough to work on in progress
Milestone
Next Release

Comments

@kaustubh-nair
Copy link
Member

kaustubh-nair commented Aug 15, 2020 •
edited by neiljp
Loading

It is not possible to edit stream name for stream messages, nor the recipient emails for private messages. Thus, we should disable cycling to these boxes when a user tries to edit the message.

Update (neiljp): This is fixed for stream messages now, and needs fixing for PMs only.
@kaustubh-nair kaustubh-nair added the enhancement New feature or request label Aug 15, 2020
@kaustubh-nair
Copy link
Member Author

This has a bit of conflict with #675, so should be fixed as a follow-up

@preetmishra
Copy link
Member

This is also evident in 6472494, i.e., the invalid stream name check can be bypassed currently.

@kaustubh-nair
Copy link
Member Author

@preetmishra What do you mean by the check can be bypassed? Can it bypassed with tab or an arrow key?

@preetmishra
Copy link
Member

preetmishra commented Aug 18, 2020 •
edited
Loading

An arrow key, which I think is what we're aiming for in this issue?

On second thought, perhaps this should be filed as another issue. Thoughts?

@kaustubh-nair
Copy link
Member Author

kaustubh-nair commented Aug 18, 2020 •
edited
Loading

I agree opened #779
This issue is about disabling focus completely while editing, because we do not have the move streams feature (which will require pop-ups anyway), hence trying to edit stream name makes no sense.

@neiljp neiljp added the help wanted This issue should be clear enough to work on label Aug 30, 2020
@neiljp neiljp added this to the Next Release milestone Aug 30, 2020
@Abhirup-99
Copy link
Contributor

I did love working on this issue.
@zulipbot claim.

@Abhirup-99 Abhirup-99 mentioned this issue Jan 9, 2021
Closed
@neiljp neiljp mentioned this issue Jan 28, 2021
Closed
2 tasks
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Jan 31, 2021
@Abhirup-99
boxes: Disable stream change during edit.
dc1cb07 
Fixes zulip#774.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Feb 17, 2021
@Abhirup-99
boxes: Disable stream change during edit.
aacda73 
Fixes zulip#774.
neiljp added a commit to neiljp/zulip-terminal that referenced this issue Mar 7, 2022
@neiljp @Abhirup-99
boxes: Disable stream change during edit.
7423415 
Fixes zulip#774.

Co-authored-by: Abhirup-99 <[email protected]>
neiljp added a commit to neiljp/zulip-terminal that referenced this issue Mar 7, 2022
@neiljp @Abhirup-99
boxes: Disable stream change during edit.
1a1c2c9 
Fixes zulip#774.

Co-authored-by: Abhirup-99 <[email protected]>
@neiljp neiljp mentioned this issue Mar 7, 2022
Closed
2 tasks
neiljp added a commit that referenced this issue Mar 13, 2022
@neiljp @Abhirup-99
boxes: Disable stream change during edit.
eddd0ef 
Partial fix for #774, for stream message edits.

Tidying and simplification of state handling by neiljp.

Co-authored-by: Abhirup-99 <[email protected]>
@neiljp neiljp added good first issue Good for newcomers and removed help wanted This issue should be clear enough to work on labels Mar 13, 2022
@neiljp
Copy link
Collaborator

neiljp commented Mar 13, 2022

Now that #1161 (#870) is merged, this leaves the private messages part to do. Anyone interested may benefit from looking at the commits merged in those PRs to see the test/code changes involved.

@neiljp neiljp added the help wanted This issue should be clear enough to work on label Apr 29, 2022
@Subhasish-Behera
Copy link
Contributor

@neiljp I would like to work on fixing the issue for PMs if nobody is working on it currently :)

@Subhasish-Behera Subhasish-Behera mentioned this issue Jan 4, 2023
Open
4 tasks
@zormit
Copy link

zormit commented May 20, 2024

@zulipbot claim

@Subhasish-Behera I'll try to get your WIP PR over the line (I'll probably open a new one soon-ish, referencing your work), it seems to be almost there :) Let me know if you're around and would like to collaborate on it.

@zormit zormit self-assigned this May 20, 2024
@zulipbot
Copy link
Member

Hello @zormit, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

1 similar comment
@zulipbot
Copy link
Member

Hello @zormit, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@zormit zormit linked a pull request May 24, 2024 that will close this issue
Open
18 tasks
zormit added a commit to zormit/zulip-terminal that referenced this issue May 24, 2024
@zormit
boxes/messages: Disable recpient editing when editing a private message.
abab4f4 
In order to fully disable editing (not only cycling to it, but e.g.
prevent editing through mouse clicks) we need to make the editing
of a message a different UI box than the usual reply.

This new box uses a urwid.Text to display the recipient information
rather than providing an editable field.

Fixes zulip#774.

Co-authored-by: zormit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zormit zormit

Labels
area: message editing enhancement New feature or request good first issue Good for newcomers help wanted This issue should be clear enough to work on in progress
Projects
None yet
Milestone
Next Release
7 participants
@zormit @neiljp @zulipbot @kaustubh-nair @preetmishra @Abhirup-99 @Subhasish-Behera